Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 30 additions & 0 deletions tests/unit/base/test_version.py
Original file line number Diff line number Diff line change
Expand Up @@ -89,3 +89,33 @@ def test_fetch_redirect(self):
response = self.client.messaging.v1.fetch(method="GET", uri="/Deactivations")

self.assertIsNotNone(response)

def test_delete_success(self):
self.holodeck.mock(
Response(201, ""),
Request(
method="DELETE",
url="https://api.twilio.com/2010-04-01/Accounts/AC123/Messages/MM123.json",
),
)
result = self.client.api.v2010.delete(
method="DELETE", uri="/Accounts/AC123/Messages/MM123.json"
)

self.assertTrue(result)

def test_delete_not_found(self):
self.holodeck.mock(
Response(404, '{"message": "Resource not found"}'),
Request(
method="DELETE",
url="https://api.twilio.com/2010-04-01/Accounts/AC123/Messages/MM456.json",
),
)

with self.assertRaises(Exception) as context:
self.client.api.v2010.delete(
method="DELETE", uri="/Accounts/AC123/Messages/MM456.json"
)

self.assertIn("Unable to delete record", str(context.exception))
2 changes: 1 addition & 1 deletion twilio/base/version.py
Original file line number Diff line number Diff line change
Expand Up @@ -236,7 +236,7 @@ def _parse_delete(self, method: str, uri: str, response: Response) -> bool:
if response.status_code < 200 or response.status_code >= 300:
raise self.exception(method, uri, response, "Unable to delete record")

return response.status_code == 204
return True # if response code is 2XX, deletion was successful

def delete(
self,
Expand Down
Loading