Skip to content

Conversation

@vungle-zhongliangong
Copy link

@vungle-zhongliangong vungle-zhongliangong commented Dec 2, 2025

Summary by CodeRabbit

  • New Features
    • The metadata response now includes a "scopes_supported" field listing supported authentication scopes (openid, profile, email), improving clarity for clients about available authorization scopes.

✏️ Tip: You can customize this high-level summary in your review settings.

@coderabbitai
Copy link

coderabbitai bot commented Dec 2, 2025

Walkthrough

The HandleProtectedResourceMetadata function in metadata.go was updated to add a new scopes_supported field to the protected resource metadata response, listing the OpenID Connect scopes: "openid", "profile", and "email". No other logic or flow was changed.

Changes

Cohort / File(s) Change Summary
Metadata field addition
metadata.go
Added scopes_supported field with values ["openid", "profile", "email"] to the protected resource metadata response in HandleProtectedResourceMetadata.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

  • Single-file change adding a static field to a response structure
  • No control-flow or business-logic changes

Poem

🐰 A scope field hops into place,
OpenID, profile, email in chase,
Metadata now shows their light,
Quietly added, tidy and right. 🥕

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main change: adding a 'scopes_supported' field to the protected resource metadata response.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 392923f and bfcaab6.

📒 Files selected for processing (1)
  • metadata.go (1 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
  • metadata.go

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No high-severity issues spotted; scopes metadata addition looks consistent with other endpoints.

Signed-off-by: Zhong Liang Ong <zong@liftoff.io>
@vungle-zhongliangong vungle-zhongliangong force-pushed the PE-XXX-update-endpoint-response branch from 392923f to bfcaab6 Compare December 2, 2025 11:54
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good—no issues found in this change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant