-
Notifications
You must be signed in to change notification settings - Fork 46
feat: Add new provider images for RhoAI configuration #565
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add new provider images for RhoAI configuration #565
Conversation
Reviewer's guide (collapsed on small PRs)Reviewer's GuideThis PR enhances the RhoAI overlay by extending its params.env file with dedicated environment variables for provider-specific container images, enabling clear, centralized image configuration for AWS, GCP, and Azure along with a default fallback. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
|
@dmaniloff: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
@dmaniloff Thanks for the PR! A few comments:
|
ruivieira
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
I suggest we hold the merge until the upstream image is built and the ODH operator PRs are approved.
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: ruivieira The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
PR image build and manifest generation completed successfully! 📦 PR image: 📦 LMES driver image: 📦 LMES job image: 📦 Guardrails orchestrator image: 🗂️ CI manifests |
0c0104c
into
trustyai-explainability:main
Add provider images for Garak & Ragas providers