Delta SPH - Boundary Condition by Marrone et al. #988
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…kThe normals are not yet computed fot corner particles.
… tank do not exist.
Added first implementation of Moving-Least Squares Kernel by Marrone. Added new struct for Pressure Extrapolation for Marrone. Added new methods to updated the pressure according to Marrone.
Fix for the offset of the boundary normals.
…l cache. Create cache for Marrone. Rename the cache creation functions to be self-explanatory. Add `particle_volume` argument to `compute_wall_velocity()`.
Update test file for MarroneMLSKernel
Contributor
Author
|
@efaulhaber Please have a look. |
svchb
reviewed
Nov 19, 2025
Collaborator
svchb
left a comment
svchb
left a comment
There was a problem hiding this comment.
For compatibility with the surface tension code the normals of the bnd should be added into the cache of the boundary system.
| end | ||
|
|
||
| # 2D | ||
| function _compute_normals(boundary_coordinates, boundary_spacing, |
Collaborator
There was a problem hiding this comment.
These functions seem to long for non-performance relevant code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This boundary condition computes the normal vectors for the dummy particles. These vectors are then used to compute certain interpolation points inside the fluid. At these interpolation points, dummy particle properties (e.g. pressure, etc.) are approximated using a Moving Least-Squares kernel.