-
Notifications
You must be signed in to change notification settings - Fork 17
Automatic ordering of clamped particles #931
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Automatic ordering of clamped particles #931
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #931 +/- ##
==========================================
+ Coverage 63.87% 63.89% +0.02%
==========================================
Files 117 117
Lines 7842 7858 +16
==========================================
+ Hits 5009 5021 +12
- Misses 2833 2837 +4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
svchb
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A test is missing.
If you remove the first option it is a breaking change.
122e5ef to
88b09e3
Compare
|
/run-gpu-tests |
|
/run-gpu-tests |
With this PR, we now have two ways to specify clamped particles:
n_clamped_particles,ensuring that these particles are the last entries in the
InitialConditionclamped_particles.In this case, the specified particles will be internally reordered so that they become
the last particles in the
InitialCondition.The second option can be helpful in more complex setups, for example, to avoid
unions.Here a snippet from the
oscillating_beam_2d.jlexample