Implement Strict Routing Semantics for Routing Rules #804
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Just a few remarks:
|
Member
+1 |
Member
Author
|
Peiyingy
changed the title
kbhatianr
reviewed
Dec 4, 2025
| List<ProxyBackendConfiguration> backends = gatewayBackendManager.getActiveBackends(routingGroup).stream() | ||
| .filter(backEnd -> isBackendHealthy(backEnd.getName())) | ||
| .toList(); | ||
| if (backends.isEmpty() && strictRouting) { |
There was a problem hiding this comment.
This may be a nitpick, but evaluating strictRouting first can short circuit the backends.isEmpty() one, in case it's false. A teeny performance optimization would be to re-order these so it's if (strictRouting && backends.isEmpty())
RoeyoOgen
reviewed
Dec 7, 2025
| .filter(backEnd -> isBackendHealthy(backEnd.getName())) | ||
| .toList(); | ||
| if (strictRouting && backends.isEmpty()) { | ||
| throw new WebApplicationException( |
Contributor
There was a problem hiding this comment.
why WebApplicationException and not IllegalStateException like in IllegalStateException("Number of active backends found zero"))
or maybe a custom Explicit Exception inherited from RouterException?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds
strictRoutingflag for routing as proposed in #797.Routing rules can now support
strictRouting: Trueto force pinning the query to the routing groupWhen
strictRouting = false (default), the routing behavior remains unchanged.When
strictRouting = true, the gateway would not fall back to default clusters if the pinned backend becomes unavailable. Instead, the query should fail immediately with a 404 error.Testing
mvn clean installTestStochasticRoutingManagerstrictRoutingflag works