Skip to content

fix: disable sync if not using traceloop #22

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 27, 2025
Merged

fix: disable sync if not using traceloop #22

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
09ce94f
fix: disable sync if not using traceloop
nirga Aug 27, 2025
a22946e
Apply suggestion from @ellipsis-dev[bot]
nirga Aug 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 4 additions & 6 deletions traceloop-sdk/sdk.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ import (
"log"
"net/http"
"os"
"strings"
"sync"
"time"

Expand Down Expand Up @@ -68,7 +69,9 @@ func (instance *Traceloop) initialize(ctx context.Context) error {

log.Printf("Traceloop %s SDK initialized. Connecting to %s\n", Version(), instance.config.BaseURL)

instance.pollPrompts()
if strings.HasSuffix(instance.config.BaseURL, "traceloop.com") {
Copy link
Contributor

@ellipsis-dev ellipsis-dev bot Aug 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider normalizing the BaseURL before checking its suffix (e.g. trimming trailing '/' and lowercasing) to avoid false negatives (e.g. 'https://api.traceloop.com/' may not match).

Suggested change
if strings.HasSuffix(instance.config.BaseURL, "traceloop.com") {
if strings.HasSuffix(strings.ToLower(strings.TrimSuffix(instance.config.BaseURL, "/")), "traceloop.com") {

instance.pollPrompts()
}
err := instance.initTracer(ctx, instance.config.ServiceName)
if err != nil {
return err
Expand All @@ -91,7 +94,6 @@ func setMessagesAttribute(span apitrace.Span, prefix string, messages []Message)
}
}


// Tool calling attribute helpers for new types
func setToolCallsAttribute(span apitrace.Span, messagePrefix string, toolCalls []ToolCall) {
for i, toolCall := range toolCalls {
Expand All @@ -105,8 +107,6 @@ func setToolCallsAttribute(span apitrace.Span, messagePrefix string, toolCalls [
}
}



func setToolsAttribute(span apitrace.Span, tools []Tool) {
if len(tools) == 0 {
return
Expand All @@ -132,7 +132,6 @@ func setToolsAttribute(span apitrace.Span, tools []Tool) {
}
}


func (instance *Traceloop) tracerName() string {
if instance.config.TracerName != "" {
return instance.config.TracerName
Expand Down Expand Up @@ -185,7 +184,6 @@ func (llmSpan *LLMSpan) LogCompletion(ctx context.Context, completion Completion
return nil
}


func (instance *Traceloop) Shutdown(ctx context.Context) {
if instance.tracerProvider != nil {
instance.tracerProvider.Shutdown(ctx)
Expand Down