This repository was archived by the owner on Jul 13, 2019. It is now read-only.
Allow end-of-namespace lines that begin with whitespace. #9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
18 tasks
tkruse
force-pushed
the
end-of-namespace
branch
6 times, most recently
from
c3177bf to
1cbd3e0
Compare
… change,
indented end-of-namespace lines (mostly due to nested namespaces) would still
cause an error even if the appropriate change is made to the line. Example:
namespace x {
namespace y {
// this is a nontrivial namespace according
// to cpplint
static const int nontrivial[] = {
0,
1,
2,
3,
4,
5,
6,
7,
8,
9,
10
};
// end of namespace y is indented, so would
// still cause an error!
} // namespace y
} // namespace x
Based on google/styleguide#17 by pocci...@gmail.com
tkruse
force-pushed
the
end-of-namespace
branch
from
1cbd3e0 to
46ce93e
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without this change,
indented end-of-namespace lines (mostly due to nested namespaces) would still
cause an error even if the appropriate change is made to the line. Example:
namespace x {
namespace y {
// this is a nontrivial namespace according
// to cpplint
static const int nontrivial[] = {
0,
1,
2,
3,
4,
5,
6,
7,
8,
9,
10
};
// end of namespace y is indented, so would
// still cause an error!
} // namespace y
} // namespace x
Based on google/styleguide#17 by pocci...@gmail.com