internal/task: create detatched threads and fix error handling #5083
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, we created joinable threads. As a result, all threads would be kept alive after completion so that pthread_join could wait for them. We never call pthread_join, so threads would never get cleaned up. Additionally, the thread creation error check was performed after waiting for the thread to start. If pthread_create failed, the caller would get stuck waiting for a thread that was never created.
This was referenced Nov 9, 2025
deadprogram
approved these changes
Nov 10, 2025
Member
deadprogram
left a comment
deadprogram
left a comment
There was a problem hiding this comment.
Very good catch on that @niaow thank you! Now merging.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, we created joinable threads.
As a result, all threads would be kept alive after completion so that pthread_join could wait for them. We never call pthread_join, so threads would never get cleaned up.
Additionally, the thread creation error check was performed after waiting for the thread to start. If pthread_create failed, the caller would get stuck waiting for a thread that was never created.