fix(rp2040): use int64 in ReadTemperature to avoid int32 overflow #5047
+2
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes the implementation of
ReadTemperaturefor the RP2040 target.The previous code used
int32intermediates, which caused arithmetic overflow when the ADC voltage deviated more than ±56 mV from 706 mV.Since the internal temperature sensor of the RP2040 typically operates between 537 mV and 821 mV (-40°C to 125°C), overflow occurred in normal conditions.
As a result, the function sometimes returned corrupted values such as
-31.8°C.Changes
ReadTemperature(RP2040) toint64.int32(milli-°C) for API compatibility.Before (buggy)
temperature: 32.8℃
temperature: 32.8℃
temperature: -31.8℃
temperature: -31.8℃
...
After (fixed)
temperature: 31.8℃
temperature: 32.8℃
temperature: 32.8℃
temperature: 32.8℃
temperature: 33.7℃
...
Impact