fix: add TryLock methods to sync.RWMutex #4987
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikesmitty
force-pushed
the
ms/add-trylock-methods
branch
from
654fb49 to
3173658
Compare
deadprogram
approved these changes
Aug 14, 2025
Member
deadprogram
left a comment
deadprogram
left a comment
There was a problem hiding this comment.
Looks good to me. @aykevl or anyone else have any comment before merge?
Member
|
@mikesmitty sorry about the late comment here, but perhaps you can add this to the tests for this? What do you think? |
Contributor
Author
|
Oh yeah, sure thing |
mikesmitty
force-pushed
the
ms/add-trylock-methods
branch
from
3173658 to
0ed7e37
Compare
Member
|
Thanks for the addition here @mikesmitty now merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I saw these were recently added to sync.Mutex, figured they should probably be on RWMutex too. Implementations sourced from big go with the race detection removed