-
Notifications
You must be signed in to change notification settings - Fork 4
feat: initial module + DA #7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 35 commits
711a8b6
cb9494f
2ecdbb7
b29584c
c808266
13c8f99
df3c030
1b9cb91
5f908cd
8198c0b
a969063
9e939dc
eaae3d2
fc9ce23
c9b83a2
5b9d124
4aa3fbc
e3ada1e
e2f7c9c
2c211b2
fe841bd
d80d603
ce0f7e1
acb982e
b7b304b
c341bb0
137a2ec
67c941a
b22a686
86e52a1
b8725c5
2fbe1fd
dfbaaee
4924c43
17ec977
ede2e70
01ebab4
4dd7a9f
78eb2cb
cb8b621
715df11
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,13 @@ | ||
| --- | ||
| apiVersion: v1 | ||
| offerings: | ||
| - name: deploy-arch-ibm-monitoring-agent | ||
| kind: solution | ||
| catalog_id: 7df1e4ca-d54c-4fd0-82ce-3d13247308cd | ||
| offering_id: b0a00765-ee91-4c2a-87fc-df46dbc58cdb | ||
| variations: | ||
| - name: fully-configurable | ||
| mark_ready: true | ||
| install_type: fullstack | ||
| pre_validation: "tests/scripts/pre-validation-deploy-slz-roks-and-obs-instances.sh" | ||
| post_validation: "tests/scripts/post-validation-deploy-slz-roks-and-obs-instances.sh" | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,2 @@ | ||
| # Primary owner should be listed first in list of global owners, followed by any secondary owners | ||
| * @jor2 @Aashiq-J |
Large diffs are not rendered by default.
| +4 −2 | module-assets/.pre-commit-config.yaml | |
| +2 −2 | module-assets/ci/install-deps.sh | |
| +1 −1 | stack-assets/.pre-commit-config.yaml |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,17 +1,6 @@ | ||
| # | ||
| # Developer tips: | ||
| # - CRA = Code Risk Analyzer (more info on CRA: https://cloud.ibm.com/docs/code-risk-analyzer-cli-plugin?topic=code-risk-analyzer-cli-plugin-cra-cli-plugin) | ||
| # - Multiple directories can be scanned by CRA. Ensure if there are any deployable architecture in the repository that they are all scanned | ||
| # - More info about supported configurations at https://github.com/terraform-ibm-modules/common-pipeline-assets/blob/main/.github/workflows/terraform-test-pipeline.md#cra-config-yaml | ||
| # | ||
|
|
||
| # More info about this file at https://github.com/terraform-ibm-modules/common-pipeline-assets/blob/main/.github/workflows/terraform-test-pipeline.md#cra-config-yaml | ||
| version: "v1" | ||
| CRA_TARGETS: | ||
| - CRA_TARGET: "examples/advanced" # Target directory for CRA scan. If not provided, the CRA Scan will not be run. | ||
| CRA_IGNORE_RULES_FILE: "cra-tf-validate-ignore-rules.json" | ||
| PROFILE_ID: "fe96bd4d-9b37-40f2-b39f-a62760e326a3" # SCC profile ID (currently set to 'IBM Cloud Framework for Financial Services' '1.7.0' profile). | ||
| # SCC_INSTANCE_ID: "" # The SCC instance ID to use to download profile for CRA scan. If not provided, a default global value will be used. | ||
| # SCC_REGION: "" # The IBM Cloud region that the SCC instance is in. If not provided, a default global value will be used. | ||
| CRA_ENVIRONMENT_VARIABLES: # An optional map of environment variables for CRA, where the key is the variable name and value is the value. Useful for providing TF_VARs. | ||
| TF_VAR_prefix: "mock" | ||
| TF_VAR_region: "us-south" | ||
| - CRA_TARGET: "examples/obs-agent-ocp" # Target directory for CRA scan. If not provided, the CRA Scan will not be run. | ||
| CRA_IGNORE_RULES_FILE: "cra-tf-validate-ignore-rules.json" # CRA Ignore file to use. If not provided, it checks the repo root directory for `cra-tf-validate-ignore-rules.json` | ||
| PROFILE_ID: "fe96bd4d-9b37-40f2-b39f-a62760e326a3" # SCC profile ID (currently set to 'IBM Cloud Framework for Financial Services' '1.7.0' profile). |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,3 +1,22 @@ | ||
| { | ||
| "scc_rules": [] | ||
| "scc_rules": [ | ||
| { | ||
| "scc_rule_id": "rule-216e2449-27d7-4afc-929a-b66e196a9cf9", | ||
| "description": "Check whether Flow Logs for VPC are enabled", | ||
| "ignore_reason": "This rule is not relevant to the module itself, just the VPC resource that is used in the example that is scanned", | ||
| "is_valid": false | ||
| }, | ||
| { | ||
| "scc_rule_id": "rule-2325054a-c338-474a-9740-0b7034487e40", | ||
| "description:": "Check whether OpenShift clusters are accessible only by using private endpoints", | ||
| "ignore_reason": "This rule is not relevant to the module itself, just the cluster resource that is used in the example that is scanned", | ||
| "is_valid": false | ||
| }, | ||
| { | ||
| "scc_rule_id": "rule-64c0bea0-8760-4a6b-a56c-ee375a48961e", | ||
| "description:": "Check whether Virtual Private Cloud (VPC) has no public gateways attached", | ||
| "ignore_reason": "This rule is not relevant to the module itself, just the VPC resource that is used in the example that is scanned", | ||
| "is_valid": false | ||
| } | ||
| ] | ||
| } |
This file was deleted.
This file was deleted.
This file was deleted.
This file was deleted.
This file was deleted.
This file was deleted.
This file was deleted.
This file was deleted.
This file was deleted.
This file was deleted.
This file was deleted.
Uh oh!
There was an error while loading. Please reload this page.