fix: strip version from kmodule image digest

[jor2]

Description

Sysdig charts don't support passing an image tag to the digest field as we get:

http://icr.io/ext/sysdig/agent-kmodule@14.2.5@sha256:0345968a77f8eb64a00f2b06af3c40bf3df78d34125b46c9788a9e73f8ddbb1a

instead of:

icr.io/ext/sysdig/agent-kmodule:14.2.5@sha256:0345968a77f8eb64a00f2b06af3c40bf3df78d34125b46c9788a9e73f8ddbb1a

We need to maintain the version 14.2.5 for renovate automation, so instead we created a local that strips at the @ symbol from 14.2.5@sha256:0345968a77f8eb64a00f2b06af3c40bf3df78d34125b46c9788a9e73f8ddbb1a so we end up only passing sha256:0345968a77f8eb64a00f2b06af3c40bf3df78d34125b46c9788a9e73f8ddbb1a.

Release required?

• No release
• Patch release (x.x.X)
• Minor release (x.X.x)
• Major release (X.x.x)

Release notes content

Run the pipeline

If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.

Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:

/run pipeline

Checklist for reviewers

• If relevant, a test for the change is included or updated with this PR.
• If relevant, documentation for the change is included or updated with this PR.

For mergers

• Use a conventional commit message to set the release level. Follow the guidelines.
• Include information that users need to know about the PR in the commit message. The commit message becomes part of the GitHub release notes.
• Use the Squash and merge option.

[ocofaigh]

If you are sure that this does not support passing an image tag (which is not the case for any of the other images used here) we should add variable validation to the input to only allow the digest format.

[jor2]

@ocofaigh docs suggest they're both enabled by default jmx, app_checks. Perhaps they were at some point. But code looks like they're actually disabled here. app_checks will be deprecated soon btw:

We are sunsetting application checks in favor of [Monitoring Integrations](https://docs.sysdig.com/en/integration-library/).

[ocofaigh]

see comments

[ocofaigh]

/run pipeline

[jor2]

/run pipeline

[ocofaigh]

The addons test failed during undeploy of the monitoring DA, however it didnt print the reason, and the workspace is gone. I have raised this with Daniel/Wesley. for now, will retry pipeline..

[ocofaigh]

/run pipeline

[terraform-ibm-modules-ops]

🎉 This PR is included in version 1.19.0 🎉

The release is available on:

• GitHub release
• v1.19.0

Your semantic-release bot 📦🚀