-
Notifications
You must be signed in to change notification settings - Fork 17
doc: deprecate in-module VPN gateway and introduce site-to-site-vpn module #1041
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
imprateeksh
wants to merge
16
commits into
main
Choose a base branch
from
deprecate_refs
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+138
−3
Open
Changes from 5 commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
20f87ed
doc: deprecation update
imprateeksh ec46e30
Merge branch 'main' into deprecate_refs
imprateeksh b89cd4e
Merge branch 'main' into deprecate_refs
imprateeksh 332cc9b
Merge branch 'deprecate_refs' of github.com:terraform-ibm-modules/ter…
imprateeksh 6e10a7a
doc: fixed typos
imprateeksh 89f369a
Merge branch 'main' into deprecate_refs
imprateeksh 61fdf25
Merge branch 'main' into deprecate_refs
imprateeksh f0479e8
Merge branch 'main' into deprecate_refs
imprateeksh 0151638
Merge branch 'main' into deprecate_refs
imprateeksh 26a2741
Merge branch 'main' into deprecate_refs
imprateeksh 336c01f
Merge branch 'main' into deprecate_refs
imprateeksh f23ebe9
Merge branch 'main' into deprecate_refs
imprateeksh a8834ef
Merge branch 'deprecate_refs' of github.com:terraform-ibm-modules/ter…
imprateeksh 723e6c4
fixed typo
imprateeksh eda44a6
Merge branch 'main' into deprecate_refs
imprateeksh 8129d43
updated variable to use default route value and add migration document
imprateeksh File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -413,6 +413,8 @@ locals { | |
| ############################################################################## | ||
| # Create VPN Gateways | ||
| ############################################################################## | ||
| # ⚠️ Provisioning of VPN Gateways will soon be deprecated. | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Maybe add URL for the |
||
| # Please refer [IBM Cloud site-to-site VPN](https://github.com/terraform-ibm-modules/terraform-ibm-site-to-site-vpn/blob/main/README.md#usage) module. | ||
|
|
||
| locals { | ||
| # Convert the vpn_gateway input from list to a map | ||
|
|
||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The root readme should not contain all this information. There should be a one liner deprecation warning at the top of the readme that point to
.docs/migration_guide.md(Also why did you make it a hidden folder (.doc) ?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Got it and my bad w.r.t hidden folder, I thought we are making use of this docs directory for documentation. I will move it out at the root level. Thank you.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In the one-liner notice add some⚠️ warning symbols, and point it to the readme file in the docs folder.