feat: Monolith example for base-ocp-vpc DA #883
Conversation
|
/run pipeline |
1 similar comment
|
/run pipeline |
|
/run pipeline |
1 similar comment
|
/run pipeline |
|
/run pipeline |
|
/run pipeline |
|
/run pipeline |
|
/run pipeline |
| cos_instance_guid = var.existing_cos_instance_crn != null ? module.existing_cos_instance_crn_parser[0].service_instance : module.cos[0].cos_instance_guid | ||
| } | ||
|
|
||
| module "cloud_logs" { |
There was a problem hiding this comment.
In addons flow, we were having dependencies on just observability instances and couldn't add dependency on observability agents because agents would be installed after cluster creation and addons flow wouldn't work for agents in that case. As now we are having a monolith example, we can call logs-agent module also. Currently we are just creating cloud logs instance but it is not used until logs-agent is installed. I suggest to include logs-agent module also.
vkuma17
left a comment
vkuma17
left a comment
There was a problem hiding this comment.
looks good overall, just have some suggestions related to observability
| }] : [] | ||
| } | ||
|
|
||
| module "cloud_monitoring" { |
There was a problem hiding this comment.
In addons flow, we were having dependencies on just observability instances and couldn't add dependency on observability agents because agents would be installed after cluster creation and addons flow wouldn't work for agents in that case. As now we are having a monolith example, we can call monitoring-agent module also. Currently we are just creating cloud monitoring instance but it is not used until monitoring-agent is installed. I suggest to include monitoring-agent module also.
Description
The PR adds a new module for monolith. This module integrates essential foundational services for security, monitoring, and logging for creating a fully configurable OCP cluster on an IBM Cloud Virtual Private Cloud. The example is added to other_tests.go
Test passed in schematics
Release required?
Adding a plain monolith example of base-ocp-vpc DA deployment by creating the add ons using terraform code.
x.x.X)x.X.x)X.x.x)Release notes content
Run the pipeline
If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.
Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:
Checklist for reviewers
For mergers