feat: Support for psc_auto_connections in mysql and postgres #739
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OscarVanL
requested review from
a team,
ayushmjain,
imrannayer and
q2w
as code owners
Contributor
Author
|
@imrannayer Please would you be able to take a look? I have tested this commit out against my (mysql) database and it works as intended. |
Collaborator
|
@OscarVanL can u plz resolve conflicts? |
Collaborator
|
/gcbrun |
1 similar comment
Collaborator
|
/gcbrun |
Collaborator
|
@OscarVanL can u plz add this to safer_mysql module? https://github.com/terraform-google-modules/terraform-google-sql-db/tree/main/modules/safer_mysql |
Collaborator
|
/gcbrun |
Collaborator
|
/gcbrun |
Contributor
Author
|
Closing as I do not need this feature anymore. Someone else could re-open the MR if they need it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #738
Adds support for the new PSC "Create the endpoint automatically" feature.