Skip to content

feat: Add reuse_interval to password validation policy configuration #687

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Feb 11, 2025
Merged

feat: Add reuse_interval to password validation policy configuration #687

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
88b7891
feat: Add reuse_interval to password validation policy configuration
anluuhoai Dec 25, 2024
b086574
update optional variable
anluuhoai Feb 6, 2025
de6f667
optional update
anluuhoai Feb 6, 2025
80f0e82
Merge branch 'main' into feat/reuse_interval_password_policy
imrannayer Feb 6, 2025
1d1ba06
readme
anluuhoai Feb 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions modules/mysql/main.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -124,6 +124,7 @@ resource "google_sql_database_instance" "default" {
min_length = lookup(password_validation_policy.value, "min_length", null)
complexity = lookup(password_validation_policy.value, "complexity", null)
disallow_username_substring = lookup(password_validation_policy.value, "disallow_username_substring", null)
reuse_interval = lookup(password_validation_policy.value, "reuse_interval", null)
}
}
dynamic "ip_configuration" {
Expand Down
1 change: 1 addition & 0 deletions modules/mysql/variables.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -336,6 +336,7 @@ variable "password_validation_policy_config" {
min_length = number
complexity = string
disallow_username_substring = bool
reuse_interval = number
Copy link
Collaborator

@imrannayer imrannayer Jan 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@anluuhoai if it is not required can u make it optional?

Copy link
Contributor Author

@anluuhoai anluuhoai Jan 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is already an option. If you don't fill it in, it will be null. In this case, I need to config the reuse_interval, but the current module doesn't have this option.
In the console, if you fill in the reuse interval, when I run this module without reuse_interval, it will remove the reuse interval.

Copy link
Contributor Author

@anluuhoai anluuhoai Jan 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

any update? @imrannayer

Copy link
Collaborator

@imrannayer imrannayer Jan 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@anluuhoai if this is not required can u plz define as optional

reuse_interval = optional(number)

Copy link
Contributor Author

@anluuhoai anluuhoai Feb 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think reuse_interval is no different from min_length or complexity @imrannayer

Copy link
Contributor Author

@anluuhoai anluuhoai Feb 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

btw, I updated.

})
default = null
}
Expand Down