-
Notifications
You must be signed in to change notification settings - Fork 1.3k
fix: Adding output types to metadata.yaml for gke-standard-cluster #2492
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Summary of ChangesHello @Saranya3, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request updates the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request correctly adds type definitions for most of the outputs in metadata.yaml for the gke-standard-cluster module. This is a good improvement for metadata completeness and will help with tooling that consumes this file. I have one suggestion to add a missing type definition for one of the outputs to make the change complete.
| - name: master_version | ||
| description: Current master kubernetes version | ||
| type: string | ||
| - name: min_master_version | ||
| description: Minimum master kubernetes version |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The min_master_version output is missing its type definition. Based on the outputs.tf file, its value is a string. Please add the type definition to be consistent with the other outputs.
- name: master_version
description: Current master kubernetes version
type: string
- name: min_master_version
description: Minimum master kubernetes version
type: string| - list | ||
| - - object | ||
| - cidr_blocks: | ||
| - set |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
would list make more sense here instead of set? Same for other places where set is used.
Added output type to metadata.yaml inorder to make connections to the gke-standard-cluster and deploy the same with connections.
Ref: https://g3doc.corp.google.com/cloud/config/gcpblueprints/g3doc/design_center.md#1-generate-output-type-in-metadata