Skip to content

Conversation

@wyardley
Copy link
Contributor

@wyardley wyardley commented Oct 29, 2024

Update the version spec of the VPC module in safer_cluster_iap_bastion.

It is likely already getting the newer version already since it's >=

Note: I'm not sure why Renovate isn't PRing updating it, unless it's the google/ in the module's path? Based on the registry, this seems like the correct way to define that specific top level module, though. Oh, maybe just because it's >= vs ~=. Let me know if you want me to make the version spec more specific.

Update the version of the VPC module in `safer_cluster_iap_bastion`
@wyardley wyardley requested review from a team, ericyz and gtsorbo as code owners October 29, 2024 18:05
@apeabody
Copy link
Collaborator

Update the version spec of the VPC module in safer_cluster_iap_bastion.

It is likely already getting the newer version already since it's >=

Note: I'm not sure why Renovate isn't PRing updating it, unless it's the google/ in the module's path? Based on the registry, this seems like the correct way to define that specific top level module, though. Oh, maybe just because it's >= vs ~=. Let me know if you want me to make the version spec more specific.

Yes - With >= it will automatically grab the newest version during init, so Renovate won't try to update. If we are going to manually bump the version, let's also switch to ~>.

Copy link
Collaborator

@apeabody apeabody left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution @wyardley!

@apeabody
Copy link
Collaborator

/gcbrun

@apeabody
Copy link
Collaborator

/gcbrun

@apeabody apeabody enabled auto-merge (squash) October 30, 2024 15:48
@apeabody apeabody self-assigned this Oct 30, 2024
@apeabody
Copy link
Collaborator

/gcbrun

@apeabody apeabody merged commit 5d1f7d4 into terraform-google-modules:master Oct 30, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants