Skip to content

chore(CI): add autopilot DefaultVerify #2153

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 28, 2024
Merged

chore(CI): add autopilot DefaultVerify #2153

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e89a90a
chore(CI): add ap defaultverify
apeabody Oct 24, 2024
1c4577b
Merge branch 'master' into ap/verify
apeabody Oct 28, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions examples/autopilot_private_firewalls/network.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,9 +23,10 @@ module "gcp-network" {

subnets = [
{
subnet_name = local.subnet_name
subnet_ip = "10.0.0.0/17"
subnet_region = var.region
subnet_name = local.subnet_name
subnet_ip = "10.0.0.0/17"
subnet_region = var.region
subnet_private_access = true
},
{
subnet_name = local.master_auth_subnetwork
Expand Down
7 changes: 4 additions & 3 deletions examples/simple_autopilot_public/network.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,9 +23,10 @@ module "gcp-network" {

subnets = [
{
subnet_name = local.subnet_name
subnet_ip = "10.0.0.0/17"
subnet_region = var.region
subnet_name = local.subnet_name
subnet_ip = "10.0.0.0/17"
subnet_region = var.region
subnet_private_access = true
},
{
subnet_name = local.master_auth_subnetwork
Expand Down
3 changes: 1 addition & 2 deletions test/integration/autopilot_private_firewalls/autopilot_private_firewalls_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,8 +26,7 @@ import (
func TestAutopilotPrivateFirewalls(t *testing.T) {
bpt := tft.NewTFBlueprintTest(t)
bpt.DefineVerify(func(assert *assert.Assertions) {
//Skipping Default Verify as the Verify Stage fails due to change in Client Cert Token
// bpt.DefaultVerify(assert)
bpt.DefaultVerify(assert)
projectId := bpt.GetStringOutput("project_id")
location := bpt.GetStringOutput("location")
clusterName := bpt.GetStringOutput("cluster_name")
Expand Down
3 changes: 1 addition & 2 deletions ...n/simple_autopilot_private_non_default_sa/simple_autopilot_private_non_default_sa_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,8 +33,7 @@ func TestSimpleAutopilotPrivateNonDefaultSA(t *testing.T) {
)

bpt.DefineVerify(func(assert *assert.Assertions) {
//Skipping Default Verify as the Verify Stage fails due to change in Client Cert Token
// bpt.DefaultVerify(assert)
bpt.DefaultVerify(assert)

location := bpt.GetStringOutput("location")
clusterName := bpt.GetStringOutput("cluster_name")
Expand Down
3 changes: 1 addition & 2 deletions test/integration/simple_autopilot_public/simple_autopiliot_public_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,8 +30,7 @@ func TestSimpleAutopilotPublic(t *testing.T) {
)

bpt.DefineVerify(func(assert *assert.Assertions) {
//Skipping Default Verify as the Verify Stage fails due to change in Client Cert Token
// bpt.DefaultVerify(assert)
bpt.DefaultVerify(assert)

projectId := bpt.GetStringOutput("project_id")
location := bpt.GetStringOutput("location")
Expand Down