feat: Adding terminal autoclass variable for simple and multiple bucket #406
Conversation
snskArora
force-pushed
the
feature/terminal_autoclass
branch
from
7d00f3b to
2d7b4ef
Compare
snskArora
changed the title
bharathkkb
left a comment
bharathkkb
left a comment
There was a problem hiding this comment.
Thanks for the PR @snskArora
variables.tf
Outdated
| type = map(string) | ||
| default = {} | ||
| validation { | ||
| condition = alltrue([for _, v in var.terminal_autoclass : var.autoclass == false || v == "NEARLINE" || v == "ARCHIVE"]) |
There was a problem hiding this comment.
Since we maintain a min TF compat with tf 1.3 we cannot use cross variable reference in validation rules (i.e checking var.autoclass) which was introduced in 1.9. If there is a validation error if this is set and autoclass is disabled could we perform a check before passing value to terminal_storage_class - something like lookup(var.autoclass..) ? lookup(var.terminal_autoclass...) : null
There was a problem hiding this comment.
Hi @bharathkkb
The lookup during the assignment would be of no use as this is specifically to root out the wrong input (basically converting the string to an enum). Since it has to be compatible with v1.3 I will remove the autoclass check from the validation block.
There was a problem hiding this comment.
Hi @bharathkkb any other change that you suggest i should do?
2 participants
This would resolve #405