-
Notifications
You must be signed in to change notification settings - Fork 286
feat(backupdr): introducing associations attached with csql instances #908
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Here is the summary of changes. You are about to add 1 region tag.
This comment is generated by snippet-bot.
|
| backup_plan_id = "my-bp" | ||
| resource_type = "compute.googleapis.com/Instance" | ||
| backup_vault = google_backup_dr_backup_vault.default.name | ||
| # log_retention_days = 2 # Only applicable for Cloud SQL |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be created in a separate PR. It's unrelated to this feature
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually both the changes were part of the same bug that is why created a single pull request.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am sorry but we would need to hold this PR for a few days as there is some issue which is being resolved , thanks!
|
The tests are failing with deletion step blocking: I'm not sure if this is an issue with the provider, or something else that's affecting resource cleanup. |
This is a timing issue in the test workflow, not a defect in the service API or the Terraform provider. The resource cleanup is happening too quickly, before the service has completed its mandatory initial operation(As soon as backup plan association is created it triggers a backup -> which is a pending operation). |
Description
Fixes #<b/454546432>
Note: If you are not associated with Google, open an issue for discussion before submitting a pull request.
Checklist
Readiness
Style
guide
Testing
I have performed tests described in the Contributing guide:
terraform applyterraform fmtcheckIntended location
Yes, this sample will be (or already is) included on cloud.google.com
Location(s):https://cloud.google.com/backup-disaster-recovery/docs/cloud-console/backup-plan-create#create and https://cloud.google.com/backup-disaster-recovery/docs/cloud-console/sql/csql-backup#configure_a_scheduled_backup
No, this sample won't be included on cloud.google.com
Reason:
API enablement
Review