fix: Security_group_tags for endpoints

[viktor-kanavchenko]

Description

Rearrange Security Group tags for Endpoints. Position generated Name tag before user input.

Motivation and Context

This change fix a bug that makes impossible to define custom Name for the SG.

Breaking Changes

none

How Has This Been Tested?

• I have updated at least one of the examples/* to demonstrate and validate my change(s)
• I have tested and validated these changes using one or more of the provided examples/* projects

• I have executed pre-commit run -a on my pull request

[bryantbiggs]

This is incorrect, it's ordered in terms of specificity

[viktor-kanavchenko]

@bryantbiggs since you close the PR, can you please help me find a way how to set a custom Name tag for Endpoint SG?

The root module from this repo has the same pattern of forming resources tags: example1, example2, example3, example4, example5, example6. The user provided tags have precedence over generated ones.

[bryantbiggs]

Why do you need to set a custom name tag on and endpoint?

[viktor-kanavchenko]

I'm sorry if I miss led you. The Name tag is needed for endpoints' Security Group. Please do not mix up with Security Group Name.
My use case - I do migration of CloudFormation template to Terraform configuration. The Name tag is already set, so I want to reflect it in my configuration. Because of the argument order in merge() function, an autogenerated value always overrides user input, and as a result terraform plan shows changes.
Another case might be do not set Name tag(to pass empty string or null).

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.