fix: Update aws_vpn_gateway_route_propagation private/intra count to …

[GrahamOHagan]

Description

Update the "aws_vpn_gateway_route_propagation" "private"/"intra" resources to count the route tables instead of the subnet.

Motivation and Context

Where there is a single route table and three subnets, e.g. when "single_nat_gateway" = true, the same propagation resource becomes managed multiple times under this module.

When switching an existing VPC from a single NAT gateway to three NAT gateways, terraform recreates the [1] and [2] under the new route tables, this removes the route from the original route table.

Breaking Changes

If already using "single_nat_gateway" = true, two terraform applies are required. One to delete the additional propagations, and another to recreate the [0] propagation. Alternatively run terraform state rm on the extra propagations.

How Has This Been Tested?

• I have updated at least one of the examples/* to demonstrate and validate my change(s)
• I have tested and validated these changes using one or more of the provided examples/* projects

• I have executed pre-commit run -a on my pull request

[github-actions]

This PR has been automatically marked as stale because it has been open 30 days
with no activity. Remove stale label or comment or this PR will be closed in 10 days

[GrahamOHagan]

This still needs review/approval.

[bryantbiggs]

this is not a valid change from what I can understand. it appears to be an issue with adopting and existing VPC created outside this module, which is not something we design for

[GrahamOHagan]

this is not a valid change from what I can understand. it appears to be an issue with adopting and existing VPC created outside this module, which is not something we design for

Hi, this is related to VPC resources created & managed by this module. The issue is one resource is managed multiple times by Terraform.

[GrahamOHagan]

Actually there is a related issue that this fix addresses: #977

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.