feat: Add skip_destroy argument in the aws_s3_bucket_public_access_bl… #352
Conversation
main.tf
Outdated
| block_public_policy = var.block_public_policy | ||
| ignore_public_acls = var.ignore_public_acls | ||
| restrict_public_buckets = var.restrict_public_buckets | ||
| skip_destroy = true |
There was a problem hiding this comment.
Replace the hardcoded value with a variable
| skip_destroy = true | |
| skip_destroy = var.skip_destroy |
Add variable declaration in variables.tf
Finally use command "pre-commit run -a" check README.md
There was a problem hiding this comment.
Made an update in accordance with your suggestions.
Thanks for the review ;)
There was a problem hiding this comment.
May I get your approval in here? @paikend
…ock and set it to true by default
antonbabenko
left a comment
antonbabenko
left a comment
There was a problem hiding this comment.
I can't push to your branch to fix the failing CI, so please do it yourself, and we are good to go.
|
@antonbabenko can I get your approval? I believe CI have passed now :) |
Almost. Please fix it. |
Update main.tf
I believe it's now finally done |
## [5.6.0](v5.5.0...v5.6.0) (2025-08-25) ### Features * Add skip_destroy argument in the aws_s3_bucket_public_access_bl… ([#352](#352)) ([8833269](8833269))
|
This PR is included in version 5.6.0 🎉 |
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
4 participants
…ock and set it to true
Description
Motivation and Context
Breaking Changes
How Has This Been Tested?
examples/*to demonstrate and validate my change(s)examples/*projectspre-commit run -aon my pull request