feat: Add optional policy to deny ssec encrypted uploads #307
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There have been incidents where leaked credentials have led to attackers encrypting S3 buckets with their own keys in a form of ransomware attack. AWS recommends implementing policy to prevent using SSEC if that is not a feature that you use in a given bucket. Reference: https://aws.amazon.com/blogs/security/preventing-unintended-encryption-of-amazon-s3-objects/
antonbabenko
pushed a commit
that referenced
this pull request
Jan 23, 2025
## [4.5.0](v4.4.0...v4.5.0) (2025-01-23) ### Features * Add optional policy to deny ssec encrypted uploads ([#307](#307)) ([cfd1452](cfd1452))
Member
|
This PR is included in version 4.5.0 🎉 |
Contributor
Author
|
As an FYI - I did just successfully test this, with and without the policy to make sure it applied correctly and that it does block attempts to put objects with SSEC. |
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
There have been incidents where leaked credentials have led to attackers encrypting S3 buckets with their own keys in a form of ransomware attack. AWS recommends implementing policy to prevent using SSEC if that is not a feature that you use in a given bucket. This PR adds an optional policy attachment that implements AWS' recommendation.
Reference:
https://aws.amazon.com/blogs/security/preventing-unintended-encryption-of-amazon-s3-objects/
Motivation and Context
Enable users to easily block the use of SSEC in their buckets, mitigating a potential avenue of attack in the event of leaked credentials.
How Has This Been Tested?
examples/*to demonstrate and validate my change(s)examples/*projectspre-commit run -aon my pull requestI have updated one of the examples, but I won't be able to test it until later. I will try to follow up soon with the results.