Skip to content

Conversation

@okanmenevseoglu
Copy link

Description

I have added a simple validation for lifecycle_rule that ensures correct configuration is passed to the module.

Motivation and Context

In my company, we experienced that passing an incorrect map doesn't break the plan & apply pipelines but it also doesn't actually apply the required change. The main reason for this change is also that the configuration in this module is slightly different than what is explained on aws_s3_bucket_lifecycle_configuration which users usually confuse with.

Breaking Changes

It is backwards compatible according to the tests I performed.

How Has This Been Tested?

  • [*] I have updated at least one of the examples/* to demonstrate and validate my change(s)
    There already are examples.
  • I have tested and validated these changes using one or more of the provided examples/* projects
    I have also tested using terraform tests and a private project
  • I have executed pre-commit run -a on my pull request

@antonbabenko
Copy link
Member

This PR is just too much... Maybe it does the purpose, but it requires 99% refactoring... closing for now.

@okanmenevseoglu
Copy link
Author

okanmenevseoglu commented Jan 21, 2025

@antonbabenko

This PR is just too much... Maybe it does the purpose, but it requires 99% refactoring... closing for now.

Could you please elaborate why this is too much and why it requires refactoring? I didn't get what you mean.

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 21, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants