Skip to content

Conversation

@Sudokamikaze
Copy link
Contributor

@Sudokamikaze Sudokamikaze commented Nov 24, 2025

Description

Guards limits_per_label_set in aws_prometheus_workspace_configuration as for_each doesn't expect null

Motivation and Context

Fixes #27

Breaking Changes

How Has This Been Tested?

  • I have updated at least one of the examples/* to demonstrate and validate my change(s)
  • I have tested and validated these changes using one or more of the provided examples/* projects
  • I have executed pre-commit run -a on my pull request

@Sudokamikaze
Copy link
Contributor Author

@bryantbiggs

Hey, excuse me for tagging you directly, I saw user reported bug (incl at the header of the PR) - could you review this PR please? thanks

@Sudokamikaze Sudokamikaze changed the title fix: Guard limits_per_label_set from passing null fix: Guard limits_per_label_set from getting null Nov 24, 2025
@bryantbiggs bryantbiggs changed the title fix: Guard limits_per_label_set from getting null fix: Skip limits_per_label_set dynamic block when set to null Nov 24, 2025
@bryantbiggs bryantbiggs merged commit 0e71e82 into terraform-aws-modules:master Nov 24, 2025
7 checks passed
antonbabenko pushed a commit that referenced this pull request Nov 24, 2025
## [4.1.1](v4.1.0...v4.1.1) (2025-11-24)

### Bug Fixes

* Skip `limits_per_label_set` dynamic block when set to `null` ([#28](#28)) ([0e71e82](0e71e82))
@antonbabenko
Copy link
Member

This PR is included in version 4.1.1 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Version 4.1.0 has broken aws_prometheus_workspace_configuration

3 participants