Skip to content

Conversation

@FlawlessByte
Copy link
Contributor

@FlawlessByte FlawlessByte commented Sep 4, 2025

Description

This PR adds a new create_alert_manager variable to the AWS Managed Service for Prometheus (AMP) Terraform module, allowing users to conditionally disable Alert Manager creation. The variable defaults to true to maintain backward compatibility.

Motivation and Context

Breaking Changes

None. This change is fully backward compatible:

  • The create_alert_manager variable defaults to true, preserving existing behavior
  • All existing configurations will continue to work without modification
  • No existing resources or configurations are affected

How Has This Been Tested?

  • I have updated at least one of the examples/* to demonstrate and validate my change(s)
    • Updated examples/complete/main.tf to include create_alert_manager = true in the main example
  • I have tested and validated these changes using one or more of the provided examples/* projects
    • Verified that the module works correctly with both create_alert_manager = true (default) and create_alert_manager = false
    • Confirmed that Alert Manager resources are only created when both create and create_alert_manager are true
    • Tested that the module maintains backward compatibility with existing configurations
  • I have executed pre-commit run -a on my pull request
    • All pre-commit hooks passed successfully
    • Documentation was auto-generated using terraform-docs
    • Code formatting and validation completed without issues

@FlawlessByte FlawlessByte changed the title feat: add the capability to disable alert manager creation feat: Add the capability to disable alert manager creation Sep 4, 2025
@bryantbiggs bryantbiggs merged commit c838818 into terraform-aws-modules:master Sep 9, 2025
7 of 8 checks passed
antonbabenko pushed a commit that referenced this pull request Sep 9, 2025
## [3.1.0](v3.0.0...v3.1.0) (2025-09-09)

### Features

* Add the capability to disable alert manager creation ([#20](#20)) ([c838818](c838818))

### Bug Fixes

* Update CI workflow versions to latest ([#18](#18)) ([69d8d68](69d8d68))
@antonbabenko
Copy link
Member

This PR is included in version 3.1.0 🎉

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 10, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add option to disable Alert Manager creation in AWS Managed Prometheus module

3 participants