Skip to content

Conversation

@erezo9
Copy link

@erezo9 erezo9 commented Dec 2, 2025

Description

Due to dependency between the terraform of eks and the managed node groups
managed node groups should be able to run on its own - while allowing running from the eks module

it seems that the change to allow this was breaking and this should allow the terraform to run correctly
this is the behavior in hybrid_node_role and karpenter submodules

Motivation and Context

fixes this issue
#3604

Breaking Changes

this shouldnt break anything since it uses the same partition and accunt

How Has This Been Tested?

  • [V ] I have updated at least one of the examples/* to demonstrate and validate my change(s)
  • [ V] I have tested and validated these changes using one or more of the provided examples/* projects
  • I have executed pre-commit run -a on my pull request

@erezo9 erezo9 changed the title change partition due to dependency in terraofmr fix: change partition due to dependency in terraform Dec 2, 2025
@erezo9 erezo9 changed the title fix: change partition due to dependency in terraform fix: Change partition due to dependency in terraform Dec 5, 2025
@erezo9
Copy link
Author

erezo9 commented Dec 5, 2025

@bryantbiggs @antonbabenko
can you please go through this PR?
it should fix some issues when creating new clusters from scratch
it goes on the same behavior as other submodules

@bryantbiggs
Copy link
Member

thank you but this is not a valid change - we are not seeing issues with new cluster creation as the module is currently configured

@bryantbiggs bryantbiggs closed this Dec 5, 2025
@erezo9
Copy link
Author

erezo9 commented Dec 5, 2025

@bryantbiggs
its only clusters with managed node groups
if i dont have a node group it works fine

@bryantbiggs
Copy link
Member

we aren't seeing any issue with those - or any of our examples/tests that we provide

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants