-
-
Notifications
You must be signed in to change notification settings - Fork 4.3k
feat: Allow using inline policy for Karpenter controller role to mitigate policy size LimitExceeded error
#3563
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Allow using inline policy for Karpenter controller role to mitigate policy size LimitExceeded error
#3563
Conversation
…dules#3512) Signed-off-by: Alexis Sellier <3765063+alexissellier@users.noreply.github.com>
Signed-off-by: Alexis Sellier <3765063+alexissellier@users.noreply.github.com>
bryantbiggs
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks great - a few minor adjustments
LimitExceeded error
Co-authored-by: Bryant Biggs <bryantbiggs@gmail.com>
Co-authored-by: Bryant Biggs <bryantbiggs@gmail.com>
Co-authored-by: Bryant Biggs <bryantbiggs@gmail.com>
Signed-off-by: Alexis Sellier <3765063+alexissellier@users.noreply.github.com>
Signed-off-by: Alexis Sellier <3765063+alexissellier@users.noreply.github.com>
bryantbiggs
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks great, thank you!
|
This PR is included in version 21.8.0 🎉 |
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
Description
Add the possibility to create inline policy instead of a managed one for the
controllerrole to overcome the characters limit.Motivation and Context
Following the discussion on #3512
Breaking Changes
No breaking change
How Has This Been Tested?
I have deployed the change on a live cluster and checked Karpenter behavior when scaling event and node termination event occurred
pre-commit run -aon my pull request