feat: Add recommended security group rule for port 10251 to match EKS addon for metrics-server
#3562
+10
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rity group rules, add TODO note to remove the metrics-server legacy port 4443 on the next breaking change
1 task
pwntr
changed the title
pwntr
changed the title
bryantbiggs
reviewed
Oct 27, 2025
Co-authored-by: Bryant Biggs <bryantbiggs@gmail.com>
bryantbiggs
changed the title
10251 to match EKS addon for metrics-server
bryantbiggs
changed the title
10251 to match EKS addon for metrics-server10251 to match EKS addon for metrics-server
antonbabenko
pushed a commit
that referenced
this pull request
Oct 27, 2025
## [21.7.0](v21.6.1...v21.7.0) (2025-10-27) ### Features * Add recommended security group rule for port `10251` to match EKS addon for `metrics-server` ([#3562](#3562)) ([de8c550](de8c550))
Member
|
This PR is included in version 21.7.0 🎉 |
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
and add TODO note to remove the metrics-server legacy port 4443 on the next breaking change
Description
metrics-server uses port 10251 as the default nowadays with the EKS provided bundle that can be installed as an addon. Port 4443 is the legacy port used by it in the past, but not anymore in the releases of the last 3 years. Addresses #3557.
Motivation and Context
Breaking Changes
no breaking change introduced, backwards compatible and just adding another recommended port to be added as a security rule. TODO note added to be considered for the next planned breaking change version bump at v22 to remove the legacy port security group rule then.
How Has This Been Tested?
examples/*projectstested with default metrics-server addon added to the list of addons, without passing any configuration changes