feat: Add ListTagsForResource to external-dns policy
#53
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The additional IAM permission was first discussed in this Github issue: kubernetes-sigs/external-dns#1019, which was implemented and the `external-dns` documentation was updated: https://github.com/tico24/external-dns/blob/master/docs/tutorials/aws.md I left the earlier `ListTagsForResource` as-is since I think earlier versions of `external-dns` might still need it.
hoangminhtu-dh
changed the title
bryantbiggs
changed the title
ListTagsForResource to external-dns policy
bryantbiggs
approved these changes
Nov 25, 2025
bryantbiggs
merged commit fc63f9f
into
terraform-aws-modules:master
7 of 8 checks passed
antonbabenko
pushed a commit
that referenced
this pull request
Nov 25, 2025
## [2.5.0](v2.4.2...v2.5.0) (2025-11-25) ### Features * Add `ListTagsForResource` to `external-dns` policy ([#53](#53)) ([fc63f9f](fc63f9f))
Member
|
This PR is included in version 2.5.0 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The additional IAM permission was first discussed in this Github issue: kubernetes-sigs/external-dns#1019, which was implemented and the
external-dnsdocumentation was updated: https://github.com/tico24/external-dns/blob/master/docs/tutorials/aws.mdI left the earlier
ListTagsForResourceas-is since I think earlier versions ofexternal-dnsmight still need it.Description
Motivation and Context
Breaking Changes
How Has This Been Tested?
examples/*to demonstrate and validate my change(s)examples/*projectspre-commit run -aon my pull request