Skip to content

Conversation

@alelb22
Copy link

@alelb22 alelb22 commented Oct 24, 2025

Description

Clarified the description of the vpc_origin_timeouts variable to make it clear that the timeouts apply to Terraform operations (create, update, delete) rather than the resource itself.

Motivation and Context

The previous description could be interpreted as affecting the runtime behavior of the VPC origin resource.
This update improves clarity by explicitly stating that the timeouts only influence Terraform’s behavior during resource lifecycle operations.

Breaking Changes

None.
This change affects documentation only and does not modify any Terraform logic or resources.

How Has This Been Tested?

  • I have updated at least one of the examples/* to demonstrate and validate my change(s)
  • I have tested and validated these changes using one or more of the provided examples/* projects
  • Confirmed that no functional changes were introduced.
  • I have executed pre-commit run -a on my pull request
pre-commit run -a
[INFO] Initializing environment for https://github.com/antonbabenko/pre-commit-terraform.
[INFO] Initializing environment for https://github.com/pre-commit/pre-commit-hooks.
[INFO] Installing environment for https://github.com/pre-commit/pre-commit-hooks.
[INFO] Once installed this environment will be reused.
[INFO] This may take a few minutes...
Terraform fmt............................................................Passed
Terraform wrapper with for_each in module................................Passed
Terraform docs...........................................................Passed
Terraform validate with tflint...........................................Passed
Terraform validate.......................................................Passed
check for merge conflicts................................................Passed
fix end of files.........................................................Passed
trim trailing whitespace.................................................Passed

@alelb22 alelb22 changed the title chore: clarify vpc-origin timeouts description Chore: clarify vpc-origin timeouts description Oct 24, 2025
@alelb22 alelb22 changed the title Chore: clarify vpc-origin timeouts description chore: Clarify vpc-origin timeouts description Oct 24, 2025
@bryantbiggs
Copy link
Member

thank you, but this is really more about the features of Terraform rather than the module https://developer.hashicorp.com/terraform/plugin/framework/resources/timeouts

This description is pretty standard and generic across our modules

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 24, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants