Skip to content

fix: Update port and protocol handling for GENEVE in aws_lb_listener #427

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
antonbabenko merged 2 commits into from
Nov 26, 2025
Merged

fix: Update port and protocol handling for GENEVE in aws_lb_listener #427

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
16c643f
fix: Update port and protocol handling for GENEVE in aws_lb_listener
DanielRis Nov 26, 2025
77d4075
Apply suggestions from code review
antonbabenko Nov 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions main.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -273,8 +273,8 @@ resource "aws_lb_listener" "this" {
}
}

port = coalesce(each.value.port, var.default_port)
protocol = coalesce(each.value.protocol, var.default_protocol)
port = contains(["GENEVE"], coalesce(each.value.protocol, var.default_protocol)) ? null : coalesce(each.value.port, var.default_port)
protocol = contains(["GENEVE"], coalesce(each.value.protocol, var.default_protocol)) ? null : coalesce(each.value.protocol, var.default_protocol)
routing_http_request_x_amzn_mtls_clientcert_header_name = coalesce(each.value.protocol, var.default_protocol) == "HTTPS" ? each.value.routing_http_request_x_amzn_mtls_clientcert_header_name : null
routing_http_request_x_amzn_mtls_clientcert_issuer_header_name = coalesce(each.value.protocol, var.default_protocol) == "HTTPS" ? each.value.routing_http_request_x_amzn_mtls_clientcert_issuer_header_name : null
routing_http_request_x_amzn_mtls_clientcert_leaf_header_name = coalesce(each.value.protocol, var.default_protocol) == "HTTPS" ? each.value.routing_http_request_x_amzn_mtls_clientcert_leaf_header_name : null
Expand Down