feat: Allow setting evaluate_target_health for Route53 records
#423
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
I've tested that by flipping the attribute back and forth between |
bryantbiggs
changed the title
evaluate_target_health for Route53 records
bryantbiggs
approved these changes
Nov 3, 2025
antonbabenko
pushed a commit
that referenced
this pull request
Nov 3, 2025
## [10.2.0](v10.1.0...v10.2.0) (2025-11-03) ### Features * Allow setting `evaluate_target_health` for Route53 records ([#423](#423)) ([ebad35b](ebad35b))
Member
|
This PR is included in version 10.2.0 🎉 |
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This module can optionally create Route53 records for the load balancers. The records are of type A, aliases.
The
aws_route53_recordresource, when created as an alias, allows setting the mandatory attributeevaluate_target_health, with possible valuestrueorfalse.This module forces
evaluate_target_health = truefor all aliases.So I allowed the users to set this attribute.
Motivation and Context
Modules should not force choices on users, when choices exist.
Also, I have other resources of this kind, and we don't always force
evaluate_target_health = truethere.Breaking Changes
None. The
evaluate_target_healthremains optional, with a default value oftruewhich matches the current behavior of the module.How Has This Been Tested?
examples/*to demonstrate and validate my change(s)examples/*projectspre-commit run -aon my pull request