Skip to content

feat!: Bump min supported version of Terraform and AWS to 1.5.7 and 6.5 respectively #411

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Sep 16, 2025
Merged

feat!: Bump min supported version of Terraform and AWS to 1.5.7 and 6.5 respectively #411

merged 7 commits into from
Sep 16, 2025

Conversation

@bryantbiggs
Copy link
Member

@bryantbiggs bryantbiggs commented Aug 26, 2025

Description

List of backwards incompatible changes

  • Terraform v1.5.7 is now minimum supported version
  • AWS provider v6.5 is now minimum supported version

Additional changes

Added

  • Support for region parameter to specify the AWS region for the resources created if different from the provider region.

Modified

  • Variable definitions now contain detailed object types in place of the previously used any type.
  • Security group rules now use a default naming scheme of <security-group-name>-<map-key> unless a more specific rule name is provided.
  • rule.actions.type has been replaced with rule.actions.<type>. See before/after below for more details.
  • query_string supports a list of key:value pairs; type definition updated to support this (i.e. was map(string) and is now list(map(string)))

Removed

  • None

Motivation and Context

Breaking Changes

  • Yes, see docs/UPGRADE-10.0.md guide

How Has This Been Tested?

  • I have updated at least one of the examples/* to demonstrate and validate my change(s)
  • I have tested and validated these changes using one or more of the provided examples/* projects
  • I have executed pre-commit run -a on my pull request

@bryantbiggs
Copy link
Member Author

bryantbiggs commented Sep 16, 2025

cc @antonbabenko if you have time/feedback on the proposed changes

antonbabenko
antonbabenko approved these changes Sep 16, 2025
View reviewed changes
Copy link
Member

@antonbabenko antonbabenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks very nice and clean!

examples/complete-nlb/variables.tf Outdated
type = string
default = "terraform-aws-modules.modules.tf"
# default = "terraform-aws-modules.modules.tf"
default = "sharedservices.clowd.haus"
Copy link
Member

@antonbabenko antonbabenko Sep 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe put it into terraform.tfvars? I'm unsure which approach is best for both of us to be able to run these examples without manual changes.

Copy link
Member Author

@bryantbiggs bryantbiggs Sep 16, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah shoot - I normally just revert any changes to this but looks like I missed these

reverted in ba1e1cf

bryantbiggs and others added 2 commits September 16, 2025 13:59
@bryantbiggs @antonbabenko
Update docs/UPGRADE-10.0.md
279c8f3 
Co-authored-by: Anton Babenko <393243+antonbabenko@users.noreply.github.com>
@bryantbiggs
fix: Revert temporary changes to example variables.tf
ba1e1cf
@bryantbiggs bryantbiggs merged commit f431c0f into terraform-aws-modules:master Sep 16, 2025
9 checks passed
@bryantbiggs bryantbiggs deleted the feat/upgrade branch September 16, 2025 19:12
antonbabenko pushed a commit that referenced this pull request Sep 16, 2025
@semantic-release-bot
chore(release): version 10.0.0 [skip ci]
c812e70 
## [10.0.0](v9.17.0...v10.0.0) (2025-09-16)

### ⚠ BREAKING CHANGES

* Bump min supported version of Terraform and AWS to 1.5.7 and `6.5` respectively (#411)

### Features

* Bump min supported version of Terraform and AWS to 1.5.7 and `6.5` respectively ([#411](#411)) ([f431c0f](f431c0f))
@antonbabenko
Copy link
Member

antonbabenko commented Sep 16, 2025

This PR is included in version 10.0.0 🎉

@bryantbiggs bryantbiggs changed the title feat!: Bump min supported version of Terraform and AWS to 1.5.7 and 6.5 respectively feat!: Bump min supported version of Terraform and AWS to 1.5.7 and 6.5 respectively Sep 17, 2025
@github-actions
Copy link

github-actions bot commented Oct 18, 2025

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 18, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@antonbabenko antonbabenko antonbabenko approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Support for region argument

2 participants

@bryantbiggs @antonbabenko