Skip to content

termux-notification-channel: Replace word splitting with an array #209

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
rangeTonic wants to merge 1 commit into
base: master
Choose a base branch
from
Open

termux-notification-channel: Replace word splitting with an array #209

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions scripts/termux-notification-channel.in
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,22 +16,22 @@ show_usage () {
exit 0
}

ARGS=""
Copy link

@asrar-mared asrar-mared Nov 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

الملفات المتغيرة

Copy link

@asrar-mared asrar-mared Nov 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ARGS=()

ARGS=()

if [ "$1" = "-d" ]; then
shift
if [ $# == 1 ]; then
ARGS="--ez delete true --es id $1"
Copy link

@asrar-mared asrar-mared Nov 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more. 

  ARGS=(--ez delete true --es id "$1")

ARGS=(--ez delete true --es id "$1")
else
show_usage
fi
else
if [ $# == 2 ]; then
ARGS="--es id $1 --es name $2"
Copy link

@asrar-mared asrar-mared Nov 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more. 

  ARGS=(--es id "$1" --es name "$2")

ARGS=(--es id "$1" --es name "$2")
else
show_usage
fi
fi


@TERMUX_PREFIX@/libexec/termux-api NotificationChannel $ARGS
Copy link

@asrar-mared asrar-mared Nov 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@TERMUX_PREFIX@/libexec/termux-api NotificationChannel "${ARGS[@]}"

@TERMUX_PREFIX@/libexec/termux-api NotificationChannel "${ARGS[@]}"
Copy link

@asrar-mared asrar-mared Nov 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

الملفات المتغيرة