Plugin support #370
Open
Plugin support #370
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chris-olszewski
approved these changes
Dec 18, 2025
Member
chris-olszewski
left a comment
chris-olszewski
left a comment
There was a problem hiding this comment.
Everything makes sense to me. Appreciate the in depth comments.
| # @param lazy_connect [Boolean] If true, there is no connection until the first call is attempted or a worker | ||
| # is created with it. Clients from lazy connections cannot be used for workers if they have not performed a | ||
| # connection. | ||
| # @param around_connect [Proc, nil] If present, this proc accepts two values: options and a block. The block is a |
Member
There was a problem hiding this comment.
Suggested change
| # @param around_connect [Proc, nil] If present, this proc accepts two values: options and a block. The block is a | |
| # @param around_connect [Proc, nil] If present, this proc accepts two values: options and a block. The block |
| ) | ||
|
|
||
| # Create a client and worker with the plugin, run workflow, confirm success | ||
| client = Temporalio::Client.connect(env.client.connection.target_host, env.client.namespace, plugins: [plugin]) |
Member
There was a problem hiding this comment.
Not too concerned since the code is pretty straightforward, but adding some test coverage for composing plugins would be nice.
Member
Author
There was a problem hiding this comment.
I may do this, though really, plugins technically shouldn't need/want to know about each other, they should just each work. So effectively it's a test to confirm two plugins work instead of just one, so I may add a second here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was changed
Added
Temporalio::Client::Plugin,Temporalio::Worker::Plugin, andTemporalio::SimplePluginand everything required to make those work.Checklist