Fix activity completion when thread interrupted flag is set

[sojanmathew]

Fix the bug where activities that return with the 'interrupted' flag set, were unable to report their completion to the server. Activities can now successfully report completion even when they have the 'interrupted' flag set.

Without this fix, activity results are not successfully reported to server ( gRPC calls in ActivityWorker.sendReply() would fail with CancellationException when they have the 'interrupted' flag set).
The fix clears the 'interrupted' flag before making gRPC calls in ActivityWorker.sendReply() and restores it afterward, ensuring:

• Activity results are successfully reported to the server
• Thread interruption semantics are preserved for worker shutdown
• All activity completion scenarios work (success/failure/cancellation)

Fixes: #731
Related: #722

What was changed

Fix the bug where gRPC calls fail when the thread's 'interrupted' flag is set, hence unable to report their completion status to the server.

Why?

The fix ensures that activities report their completion status to the Temporal server, while maintaining proper thread interruption semantics for the worker shutdown process.
According to the issue description and PR #722, the issue was that when an activity has 'interrupted' flag set:
i.e,
1 Catches an InterruptedException
2 Restores the 'interrupted' flag (Thread.currentThread().interrupt())
3 Continues to run and returns a result

The subsequent gRPC calls in ActivityWorker.sendReply() would fail with CancellationException ( gRPC request was
cancelled because the 'interrupted' flag was still set), hence activity result were not reported to the server.

The CancellationException is thrown in GrpcSyncRetryer when reporting activity completion results:

      
  } catch (InterruptedException e) {                                                                                  
    Thread.currentThread().interrupt();                                                                               
    throw new CancellationException();                                                                                
  }

Solution
Modify ActivityWorker.sendReply() method to:

1 Check the 'interrupted' flag before making gRPC calls using Thread.interrupted() (which also clears the flag)
2 Temporarily clear the flag to allow gRPC calls to succeed
3 Make the gRPC call to report the activity result
4 Restore the 'interrupted' flag in a finally block if it was originally set

@Spikhalskiy

Checklist

1. Closes Activities that return with interrupted flag should be successfully reported as Completed #731

2. How was this tested:

   1 Created and ran a comprehensive test that reproduces the exact scenario described in the bug report
   2 Verified the test failed before the fix (confirming the bug existed)
   3 Verified the test passes after the fix (confirming the bug is resolved)
   4 Ran existing shutdown tests to ensure no regressions were introduced

3. Any docs updates needed?
   No

[CLAassistant]

All committers have signed the CLA.

[CLAassistant]

Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.

---

Sojan Mathew seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
_{You have signed the CLA already but the status is still pending? Let us recheck it.}

[Quinn-With-Two-Ns]

What part of the SDK relies on it being restored?

[sojanmathew]

What part of the SDK relies on it being restored?
@Quinn-With-Two-Ns
The CancellationException is thrown in GrpcSyncRetryer when reporting activity completion results:

      
  } catch (InterruptedException e) {                                                                                  
    Thread.currentThread().interrupt();                                                                               
    throw new CancellationException();                                                                                
  }      

[sojanmathew]

@Quinn-With-Two-Ns Are you good with above change, if so, could you please approve PR?

[Quinn-With-Two-Ns]

@sojanmathew no I still don't understand the logic here, why is the flag being restored?

[sojanmathew]

@Quinn-With-Two-Ns

• Why Restoration is Critical:

  • Java Best Practices: Interrupted state should be preserved to prevent "swallowing" interrupts
  • Contract Preservation: The gRPC operation should be transparent to interrupt state
  • Calling Code Expectations: Framework or user code may check interrupt status after completion

Hope the test helps to explain before / after situation.
In summary :

• Activity sets interrupted flag → Store original flag → Clear flag → gRPC call succeeds → Restore original flag .
  Please let me know if it clarifies or still not clear.