Fix canceling external workflows that are children in testsuite #1968
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Do you know why the feature tests are failing for your PR? |
Contributor
Author
|
Seems like it was a transient issue, features tests are passing now after merging with master |
| env.postCallback(func() { | ||
| env.onChildWorkflowCanceledListener(env.workflowInfo) | ||
| }, false) | ||
| sd.dispatcher.NewCoroutine(sd.rootCtx, "cancel-self", true, func(ctx Context) { |
Contributor
There was a problem hiding this comment.
isn't running the postCallback enough?
Contributor
Author
There was a problem hiding this comment.
Added a comment explaining why this would be needed, not sure it's worth a larger refactor, lmk if you think otherwise
// The way testWorkflowEnvironment is setup today, we close the child workflow dispatcher before calling
// the workflowCancelHandler. A larger refactor would be needed to handle this similar to non-test code.
// Maybe worth doing when https://github.com/temporalio/go-sdk/issues/50 is tackled.
yuandrew
changed the title
| // the workflowCancelHandler. A larger refactor would be needed to handle this similar to non-test code. | ||
| // Maybe worth doing when https://github.com/temporalio/go-sdk/issues/50 is tackled. | ||
| if sd, ok := env.workflowDef.(*syncWorkflowDefinition); ok && env.isChildWorkflow() { | ||
| sd.dispatcher.NewCoroutine(sd.rootCtx, "cancel-self", true, func(ctx Context) { |
Contributor
There was a problem hiding this comment.
Will this run immediately? Any compatibly concern with running this in a coroutine now and changing the sequence with onChildWorkflowCanceledListener?
Contributor
Author
There was a problem hiding this comment.
good callout, the onChildWorkflowCanceledListener logic should only run during the coroutine we spawn
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was changed
Dispatch a new coroutine with workflow context when canceling external workflow in workflow testsuite
Why?
Fix testsuite specific error
Checklist
Closes Getting a strange error when writing tests which does not occur in real temporal deployment #1961
How was this tested:
Added test
Note
When canceling the current (child) workflow via external cancel, run the cancel handler in a new dispatcher coroutine to avoid illegal access errors; add a test covering this path.
RequestCancelExternalWorkflowtargeting the current workflow, wrap cancel logic incancelFuncand, if a child workflow with*syncWorkflowDefinition, dispatch it via a new coroutine on the workflow dispatcher; otherwise call directly. Ensures child-cancel flows run within workflow context.SleepHour,SleepThenCancelworkflows andTestRequestCancelExternalWorkflowInSelectorto validate canceling an external child workflow (timer cancel path) succeeds without "illegal access" errors.Written by Cursor Bugbot for commit 1edd76a. This will update automatically on new commits. Configure here.