changes for camera filter #26
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
preek0719
commented
May 22, 2025
preek0719
commented
- Added changes for displaying dropdown populated with camera values for selected rover
- Added changes for displaying images based on selected camera angle
- Pending tests for new changes
✅ Deploy Preview for gregarious-otter-866740 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
| import { Link, Route, BrowserRouter as Router, Routes } from "react-router"; | ||
| import ProfilePage from "./components/ProfilePage"; | ||
| import PhotoOfTheDay from "./Components/photoOfTheDay/photoOfTheDay"; | ||
| // import ProfilePage from "./Components/ProfilePage"; |
| }; | ||
|
|
||
| describe("Testing the rover image displayed on page load", () => { | ||
| // const mock_cameras = ["HAZ", "CHEM"]; |
| expect(firstTestImageDiv).toHaveAttribute("aria-hidden", "true"); | ||
| }); | ||
| }); | ||
|
|
Contributor
There was a problem hiding this comment.
Are these commented out because they don't work yet?
| img_src: string; | ||
| }; | ||
|
|
||
| type Cameras = Array<string>; |
Contributor
There was a problem hiding this comment.
I don't think you really need this, you can just use string[] throughout the code and it's just as clear
| </Slider> | ||
| <select id="dropdown" value={selectedValue} onChange={handleChange}> | ||
| {latestCameras?.map((camera, index) => ( | ||
| <option key={index} value={camera}> |
Contributor
There was a problem hiding this comment.
Is it possible to unselect a camera once one has been selected? Can I just show all photos?
Collaborator
Author
There was a problem hiding this comment.
No, that isn't in place yet. It defaults to one angle on page load and there are just the options to change angles.
Collaborator
Author
|
Submitting another PR with changes incorporated |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.