Add catch2 fallback #30
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alt-graph
requested review from
Finii,
MissPeppermintPatty,
Copilot,
ohensler and
wyrnat
There was a problem hiding this comment.
Pull Request Overview
This PR ensures compatibility with older Meson releases by requiring Catch2 ≥3.4.1 and adding an explicit fallback, and updates the Catch2 wrap to file-based distribution at version 3.8.1.
- Bump Catch2 dependency version to
>=3.4.1and add afallbackclause intests/meson.build - Convert
catch2.wrapfrom git-based to file-based wrap for Catch2 v3.8.1 and adjust provided dependency names
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| tests/meson.build | Updated Catch2 dependency version and added fallback tag |
| subprojects/catch2.wrap | Swapped to [wrap-file] for Catch2 v3.8.1 and renamed provide entries |
Comments suppressed due to low confidence (2)
subprojects/catch2.wrap:11
- The provided dependency name uses a hyphen (
catch2-with-main) instead of the original underscore (catch2_with_main). Renaming it back tocatch2_with_mainmaintains consistency with existing wraps and avoids breaking consumers.
catch2-with-main = catch2_with_main_dep
tests/meson.build:15
- [nitpick] Consider adding a brief comment explaining why the fallback is needed for historic Meson versions to improve maintainability and onboarding.
dependency('catch2', version : '>=3.4.1',
For historic Meson versions, we need to add an explicit fallback tag to the dependency. Catch2 is available in the needed form since version 3.4.1, not 3.4.0. Signed-off-by: Lars Froehlich <lars.froehlich@desy.de>
alt-graph
force-pushed
the
add_catch2_fallback
branch
from
b4b4f9c to
b2019b6
Compare
Finii
approved these changes
Jun 16, 2025
Member
Author
|
Thanks, @Finii! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For historic Meson versions, we need to add an explicit fallback tag to the
catch2dependency. Catch2 is available in the needed form since version 3.4.1, not 3.4.0.