Meson: Replace homebrew catch2 wrap file with WrapDB one #29
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This replaces the previous wrap file with the latest "official" one from the WrapDB under https://mesonbuild.com/Wrapdb-projects.html. Signed-off-by: Lars Froehlich <lars.froehlich@desy.de>
alt-graph
requested review from
Finii,
MissPeppermintPatty,
Copilot,
ohensler and
wyrnat
There was a problem hiding this comment.
Pull Request Overview
This PR replaces the Homebrew-based Catch2 wrap with the official WrapDB version (v3.8.1), updating metadata and dependency mappings accordingly.
- Switched from a
[wrap-git]stanza to a[wrap-file]using Catch2 v3.8.1 from WrapDB - Updated
source_url,source_hash, and addedwrapdb_versionand fallback URL - Adjusted provided dependency names to align with the new wrap
Comments suppressed due to low confidence (3)
subprojects/catch2.wrap:11
- The key
catch2-with-mainuses a hyphen, while the other keycatch2does not. For consistency, consider renaming tocatch2_with_main.
catch2-with-main = catch2_with_main_dep
subprojects/catch2.wrap:2
- [nitpick] Consider using a lowercase directory name (e.g.,
catch2-3.8.1) for consistency with other subproject directories and to avoid potential platform case-sensitivity issues.
directory = Catch2-3.8.1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This replaces the previous wrap file with the latest "official" one from the WrapDB under https://mesonbuild.com/Wrapdb-projects.html.