feat: run unit tests on Windows #842
Merged
+89
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bhearsum
force-pushed
the
push-mxtytuktmlwk
branch
from
4452134 to
29d01f8
Compare
bhearsum
added a commit
to bhearsum/fxci-config
that referenced
this pull request
Oct 28, 2025
I'd like to start running taskgraph tests on Windows and macOS (taskcluster/taskgraph#842). This ought to add a usable Windows worker pool. Unfortunately, when I tried it out by hand I ended up with errors such as: ``` Resource /subscriptions/108d46d5-fe9b-4850-9a7d-8c914aa6c1f0/resourceGroups/rg-central-us-taskgraph-t/providers/Microsoft.Network/virtualNetworks/vn-central-us-taskgraph-t/subnets/sn-central-us-taskgraph-t referenced by resource /subscriptions/108d46d5-fe9b-4850-9a7d-8c914aa6c1f0/resourceGroups/rg-taskcluster-worker-manager-production/providers/Microsoft.Network/networkInterfaces/nic-qf0rebyslglv1wvqkn9d was not found. Please make sure that the referenced resource exists, and that both resources are in the same region. ``` ...so I suspect something else will be needed.
bhearsum
force-pushed
the
push-mxtytuktmlwk
branch
from
29d01f8 to
f3c8388
Compare
bhearsum
added a commit
to mozilla-releng/fxci-config
that referenced
this pull request
Oct 29, 2025
I'd like to start running taskgraph tests on Windows and macOS (taskcluster/taskgraph#842). This ought to add a usable Windows worker pool. Unfortunately, when I tried it out by hand I ended up with errors such as: ``` Resource /subscriptions/108d46d5-fe9b-4850-9a7d-8c914aa6c1f0/resourceGroups/rg-central-us-taskgraph-t/providers/Microsoft.Network/virtualNetworks/vn-central-us-taskgraph-t/subnets/sn-central-us-taskgraph-t referenced by resource /subscriptions/108d46d5-fe9b-4850-9a7d-8c914aa6c1f0/resourceGroups/rg-taskcluster-worker-manager-production/providers/Microsoft.Network/networkInterfaces/nic-qf0rebyslglv1wvqkn9d was not found. Please make sure that the referenced resource exists, and that both resources are in the same region. ``` ...so I suspect something else will be needed.
bhearsum
force-pushed
the
push-mxtytuktmlwk
branch
10 times, most recently
from
c86db17 to
bc5da0e
Compare
bhearsum
force-pushed
the
push-mxtytuktmlwk
branch
9 times, most recently
from
3125046 to
e91a1a3
Compare
bhearsum
changed the title
bhearsum
force-pushed
the
push-mxtytuktmlwk
branch
from
e91a1a3 to
6d4dd73
Compare
A number of tests currently fail on Windows. Some of them seem like they'll never work, while we may able to get some of them passing with some work. In the short term, just mark them as skipped to allow Windows in CI to land.
bhearsum
force-pushed
the
push-mxtytuktmlwk
branch
from
6d4dd73 to
81c6b3a
Compare
ahal
approved these changes
Nov 24, 2025
| command: >- | ||
| python3 -V && | ||
| pwd && | ||
| powershell -ExecutionPolicy ByPass -c 'irm https://astral.sh/uv/install.ps1 | iex' && |
Collaborator
There was a problem hiding this comment.
Fyi there's an exec-with: powershell key you could add here to just execute the payload via powershell entirely:
https://github.com/taskcluster/taskgraph/blob/main/src/taskgraph/transforms/run/run_task.py#L80
Just mentioning it in case you weren't aware and this somehow makes things easier. The solution you ended up with is totally fine.
Contributor
Author
There was a problem hiding this comment.
TIL - that's useful to know. I think I'll stick with what I have, partly because I know it works, and partly because the powershell is only there because it's the recommended way to install uv on Windows. Keeping this bash-oriented is useful for consistency, I think.
bhearsum
force-pushed
the
push-mxtytuktmlwk
branch
from
81c6b3a to
a040213
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's a number of tests that currently fail on Windows. This PR marks them as skipped. Some of them might pass with some work, but I'd prefer to get basic tests running sooner.
One notable downside to this is that because of how long it often takes to spin up Windows workers, getting full CI results takes longer than it used to. I think this is preferable to having no coverage...but opinions may vary. One way to work around this would be to run Windows (and maybe Mac?) tests on GHA instead, as weird and awful as that seems for Taskgraph.