crud: refactor optional types to use go-option #498
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Remove: OptUint, OptInt, OptFloat64, OptString, OptBool, OptTuple.
- Remove: MakeOptUint, MakeOptInt, MakeOptFloat64, MakeOptString, MakeOptBool, MakeOptTuple.
- Add: OptAny = option.Generic[interface{}] .
- Add: MakeOptAny constructor.
- Update: All option structs to use option.* types.
- Fix: Test type inconsistencies.
Changed #492
Collaborator
Author
|
Later, I'll add the Tuple and Any type to the go-option library and make the code even more typesafe. |
oleg-jukovec
requested changes
Nov 25, 2025
| VshardRouter option.String | ||
| // Fields is field names for getting only a subset of fields. | ||
| Fields OptTuple | ||
| Fields OptAny // Type Any is instead of a local type Tuple. |
Collaborator
There was a problem hiding this comment.
Please, add the option.Any type into the go-option library. Users won't be confused then with the own type.
Comment on lines
+15
to
+16
| * Added missing IPROTO feature flags to greeting negotiation | ||
| (iproto.IPROTO_FEATURE_IS_SYNC, iproto.IPROTO_FEATURE_INSERT_ARROW) (#466). |
Collaborator
There was a problem hiding this comment.
Please, move the changelog entry in a separate commit.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed #492