Skip to content

Do not allow empty wish #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Do not allow empty wish #6

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
8e7faa9
Do not allow empty wish
rafeuddaraj Nov 11, 2023
ed5f49b
Delete src/AddToBucket.jsx
rafeuddaraj Nov 11, 2023
ef4fde3
Do not allow empty wish
rafeuddaraj Nov 11, 2023
e9a3775
Merge branch 'main' of https://github.com/rafeuddaraj/solid-bucket-list
rafeuddaraj Nov 11, 2023
fe72c10
Add functionality to delete a wish #2
rafeuddaraj Nov 11, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
58 changes: 32 additions & 26 deletions src/AddToBucket.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,30 +1,36 @@
import { createSignal } from "solid-js";

export function AddToBucket(props) {
const [newItem, setNewItem] = createSignal('');
const [newItem, setNewItem] = createSignal("");

return (
<form>
<input
type="text"
placeholder="Make a wish"
value={newItem()}
onChange={(e) => {
setNewItem(e.target.value);
}}
/>
<button
type="submit"
onClick={(e) => {
e.preventDefault();
props.setItems((items) => {
return [...items, { text: newItem(), complete: false }].reverse();
});
setNewItem('');
}}
>
Add
</button>
</form>
);
}
return (
<form>
<input
type="text"
placeholder="Make a wish"
value={newItem()}
onChange={(e) => {
setNewItem(e.target.value);
}}
/>
<button
type="submit"
onClick={(e) => {
e.preventDefault();
if (newItem()!=='') {
props.setItems((items) => {
return [
...items,
{ text: newItem(), complete: false },
].reverse();
});
setNewItem("");
} else {
alert(`You can't submit empty value`);
}
}}>
Add
</button>
</form>
);
}
64 changes: 39 additions & 25 deletions src/BucketListItem.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,28 +1,42 @@
export function BucketListItem(props) {
return (
<li
class="list-item"
style={{
"text-decoration": props.item.complete ? "line-through" : undefined,
}}
>
<label>
<input
type="checkbox"
checked={props.item.complete}
onChange={() => {
props.setItems((items) => {
const newItems = items.map((item) =>
props.item === item
? { ...item, complete: !item.complete }
: item
);
return newItems;
const { item, setItems } = props;

const handleDelete = () => {
setItems((prevItems) => {
return prevItems.filter((prevItem) => {
return prevItem.text !== item.text;
});
}}
/>
{props.item.text}
</label>
</li>
);
});
};

return (
<li
class="list-item"
style={{
"text-decoration": props.item.complete
? "line-through"
: undefined,
}}>
<label>
<input
type="checkbox"
checked={props.item.complete}
onChange={() => {
props.setItems((items) => {
const newItems = items.map((item) =>
props.item === item
? { ...item, complete: !item.complete }
: item
);
return newItems;
});
}}
/>
{props.item.text}
</label>
<button onClick={handleDelete} style={{ "margin-left": "10px" }}>
Copy link
Contributor

@atapas atapas Nov 13, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This issue doesn't require the delete wish functionality. Delete wish is a separate issue and in open source project management we follow one issue vs one pull request.

Please remove the code for delete issue and only fix the issue asked for.

Delete
</button>
</li>
);
}