Simplify progress bar display logic #271
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jserv
requested changes
Mar 17, 2025
Contributor
jserv
left a comment
jserv
left a comment
There was a problem hiding this comment.
Rebase the latest master branch, which was forcefully pushed.
Refactor the progress bar logic to remove redundant conditional handling for the final 100% case. Instead of using a special case to clear and reprint the final bar, the update now ensures a consistent format for all progress levels. Co-authored-by: Po-Ying Chiu <charlie910417@gmail.com> Change-Id: Id2760db0c4ff2b4eaa75e97f04b0178de4ca63a3
EricccTaiwan
force-pushed
the
fix-progess-bar
branch
from
6b7b2c8 to
4a2ff9f
Compare
Contributor
|
Thank @EricccTaiwan for contributing! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor the progress bar logic to remove redundant conditional handling for the final 100% case. Instead of using a special case to clear and reprint the final bar, the update now ensures a consistent format for all progress levels.
Change-Id: Ie424815310c18b0b021d53bf9652d590da1bf5ab