-
Notifications
You must be signed in to change notification settings - Fork 4
chore: enhance project maintenance and migrate to MUI v5 #30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
tembleking
wants to merge
27
commits into
main
Choose a base branch
from
chore-enhance-project
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… adds more diverse mock data entries to the Sysdig API client for development and testing purposes. Encountered and did not resolve persistent ESLint configuration errors related to @typescript-eslint/no-unused-expressions. A separate task is needed to address the linter setup.
…ues in SysdigPostureFetchComponent.tsx\n\nThis commit refactors SysdigPostureFetchComponent.tsx to ensure React Hooks are called unconditionally, addressing the react-hooks/rules-of-hooks error. It also fixes various other linting issues in the file, including prefer-const, no-var, eqeqeq, prefer-template, and no-else-return. Additionally, it updates package.json and yarn.lock to properly include eslint, @typescript-eslint/* and eslint-formatter-friendly as dev dependencies, which resolved the initial linter setup errors.
…ues in SysdigVMPipelineFetchComponent.tsx\n\nThis commit refactors SysdigVMPipelineFetchComponent.tsx to ensure React Hooks are called unconditionally, addressing the react-hooks/rules-of-hooks error. It also fixes various other linting issues in the file, including prefer-const, no-var, eqeqeq, prefer-template, and no-else-return.
…ues in SysdigVMRegistryFetchComponent.tsx\n\nThis commit refactors SysdigVMRegistryFetchComponent.tsx to ensure React Hooks are called unconditionally, addressing the react-hooks/rules-of-hooks error. It also fixes various other linting issues in the file, including prefer-const, no-var, eqeqeq, prefer-template, and no-else-return.
…ues in SysdigVMRuntimeFetchComponent.tsx\n\nThis commit refactors SysdigVMRuntimeFetchComponent.tsx to ensure React Hooks are called unconditionally, addressing the react-hooks/rules-of-hooks error. It also fixes various other linting issues in the file, including prefer-const, no-var, eqeqeq, prefer-template, and no-else-return.
…s the remaining linting issues across multiple files:\n- : Fixes by changing to for .\n- : Fixes , , and issues in and .\n- : Addresses a comprehensive list of linting issues, including , , , , , , , , , , , and .\n- : Fixes errors in block comments.
… addresses the final specific linting issues:\n- : Fixes errors for and components.\n- : Fixes by replacing with for null checks.\n- : Fixes by removing a duplicate import and by adding a space after in a comment.
…d just to flake.nix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This introduces several key enhancements to the project configuration and codebase, focusing on modernization and maintenance.
🚧 Development
just startthe UI is working properly, without the need of a full blown backstage installation. This allows faster feedback loop with auto-reload of the changes.📦 Refactor: MUI v5 Migration
@material-ui/core,@material-ui/icons) to MUI v5 (@mui/material,@mui/icons-material).package.jsondependencies and component imports to reflect this change.AGENTS.mddocumentation to reference the new styling library.🧹 Dependency Cleanup
dependenciesanddevDependenciesfrompackage.jsonto improve project hygiene and reduce install time.🛠️ Tooling & CI Enhancements
auditcommand (yarn npm audit) for security checks.cleancommand to ensure dependencies are installed first.just lintandjust test, ensuring consistency between local development and pre-commit checks.