Use ::class constant
#554
Merged
Use ::class constant
#554
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HypeMC
commented
Oct 27, 2025
Comment on lines
-447
to
-452
| if (!interface_exists('Monolog\ResettableInterface')) { | ||
| $this->markTestSkipped('The ResettableInterface is not available.'); | ||
| } |
Member
Author
There was a problem hiding this comment.
Another thing I spotted while doing this.
HypeMC
force-pushed
the
use-class-constant
branch
from
03c1fa2 to
55c44e1
Compare
HypeMC
force-pushed
the
use-class-constant
branch
from
55c44e1 to
fc36540
Compare
GromNaN
approved these changes
Oct 27, 2025
Member
|
Thank you @HypeMC. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, we have a mix of strings and constants. I suggest using constants everywhere. This actually helped me spot #553.
I targeted 4.x because there would be a lot of conflicts if done on 3.x.
Also, I intentionally didn't import non-Symfony classes, as I think this is more readable. That's just my opinion though, I'm fine with imports as well.